NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 950 - Add a way for users to filter out particular classes of error messages.
Add a way for users to filter out particular classes of error messages.
Status: RESOLVED FIXED
Product: Validator.nu
Classification: Unclassified
Component: Browser-based UI
HEAD
All All
: P2 normal
Assigned To: Michael[tm] Smith
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-24 17:14 CET by Michael[tm] Smith
Modified: 2014-07-14 07:31 CEST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2012-11-24 17:14:45 CET
It would be great to add a client-side mechanism for users to persistently filter out particular classes of error messages, similar to http://validator.keegan.st/
Comment 1 Michael[tm] Smith 2012-12-03 06:30:57 CET
I have a working implementation of this now at http://qa-dev.w3.org:8888/
Comment 2 Henri Sivonen 2012-12-04 14:25:36 CET
This looks pretty cool. However, since the filter is remembered across validations (good), there should probably be some indicator around the filtering button saying that filtering is in effect.
Comment 3 Michael[tm] Smith 2012-12-04 14:39:25 CET
(In reply to comment #2)
> This looks pretty cool. However, since the filter is remembered across
> validations (good), there should probably be some indicator around the
> filtering button saying that filtering is in effect.

I reckon that's easy enough to add. Do you have suggestions on exactly what it should say?

I'm thinking it should include a count of how many messages are actually hidden due to filtering being in effect. So, something simple like "7 messages filtered."
Comment 4 Henri Sivonen 2012-12-04 14:51:37 CET
Maybe even something more explicit like “N messages hidden by filter”
Comment 5 Michael[tm] Smith 2012-12-04 19:45:42 CET
(In reply to comment #4)
> Maybe even something more explicit like “N messages hidden by filter”

OK, have added that now and pushed it to http://qa-dev.w3.org:8888 (to see it you may need to reload a few times or otherwise force your browser to load from cache).

I went with "N messages hidden by filtering" (rather than just "filter") because "filtering" sounds better than "filter" singular, and also I guess it's more accurate in that it's the name of the feature ("Message filtering").

Note that the count updates dynamically if you click any of the checkbox controls or show-all/hide-all links.
Comment 6 Michael[tm] Smith 2012-12-05 07:34:33 CET
At the risk of bikeshedding the wording on this: I'd kind of prefer that the top-level indicator not explicitly use the word "hidden" if we can. So I propose instead having it just say, "Filtered N messages".

The reason is, saying that some messages are "hidden" sorta implies that they should ideally be shown, and that the user is doing something wrong by "hiding" them. "Filter" on its own is a much more neutral term that doesn't imply any kind of value judgement: the user is just filtering out some messages that they've decided at some point they don't need to see every time.

For the same reason I think it would be better to change the "Hide all" links to say, "Filter out all" instead.

The context of this, I really would like for this feature to help make it easier for users to not focus on making their content 100% valid just for the sake of being able to say it's 100% valid, and to be able to see a results page without any errors/warning/info messages shown, and not be made to feel like they're doing something wrong.

I realize that could be open to abuse by some users who would just end up selecting "Filter out all errors" all the time -- or least, filter out some errors that they really should not be filtering out.

Anyway, I realize I'm probably wringing my hands about this too much, and maybe the difference between "N messages hidden by filtering" and "Filtered N messages" is too subtle to be of concern to most users.
Comment 7 Simon Pieters 2012-12-05 15:32:31 CET
I think "hidden" and "hide" are clearer than "filtered" or "filter out". The latter can be interpreted as either "hide" or "show".
Comment 8 Michael[tm] Smith 2012-12-05 15:43:37 CET
(In reply to comment #7)
> I think "hidden" and "hide" are clearer than "filtered" or "filter out". The
> latter can be interpreted as either "hide" or "show".

True. So I reckon I'll leave them as-is, then
Comment 9 Henri Sivonen 2012-12-11 15:59:42 CET
I agree with zcorpan.
Comment 10 Michael[tm] Smith 2012-12-11 16:58:18 CET
(In reply to comment #9)
> I agree with zcorpan.

Yeah, I can see that you guys are right, so I'll keep it as "hidden" and "hide". It's clear and it matches user expectations from similar kinds of applications, I think.
Comment 11 Michael[tm] Smith 2014-07-14 07:31:41 CEST
landed the backend for this quite a while back