NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 690 - make PrudentHttpEntityResolver connectionTimeout and socketTimeout configurable
make PrudentHttpEntityResolver connectionTimeout and socketTimeout configurable
Status: RESOLVED FIXED
Product: Validator.nu
Classification: Unclassified
Component: General
HEAD
All All
: P2 enhancement
Assigned To: Michael[tm] Smith
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-09 12:43 CET by Michael[tm] Smith
Modified: 2009-12-22 08:43 CET (History)
0 users

See Also:


Attachments
patch (2.10 KB, patch)
2009-12-11 13:22 CET, Michael[tm] Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2009-12-09 12:43:40 CET
The VerifierServlet code currently causes PrudentHttpEntityResolver to be called with hard-coded values of 5 seconds (5000ms) set for both the connectionTimeout and socketTimeout params. I notice a lot of cases of v.nu failing to be able check sites because those timeouts are too short (e.g., http://krijnhoetmer.nl/irc-logs/whatwg/20091208). So it would seem to be useful to make those timeouts configurable through Java system properties -- nu.validator.servlet.connectionTimeout and nu.validator.servlet.socketTimeout, I guess -- rather than hard-coding them.
Comment 1 Michael[tm] Smith 2009-12-11 13:22:50 CET
Created attachment 131 [details]
patch