Bugzilla – Bug 660
Add support for static inner classes to the Java-to-C++ translator
Last modified: 2009-10-03 12:04:16 CEST
Created attachment 116 [details] Patch to support translating static inner classes. I decided to try my hand at this mostly to gain some experience with the translator, but I also believe it will prove useful for encapsulation, especially in the Tokenizer. The trickiest part was handling HVisitor.previousVisibility correctly, so that the visibility modifiers within the inner class declaration don't affect those following the declaration.
Comment on attachment 116 [details] Patch to support translating static inner classes. This patch isn't quite right. The method definitions in the .cpp file need the enclosing::type:: qualifiers.
Created attachment 118 [details] WIP-2 Now handling inner(-inner)* classes properly, and using appropriate scope::qualifiers:: wherever these classes (or their members) are referred to. For example, static methods calls such as Tokenizer.SomeInnerClass.create() can be translated into appropriate C++ (nsHtml5Tokenizer::nsHtml5SomeInnerClass::create()). I feel a lot better about this patch but I'm still going to call it a work in progress because it's 2am and I've only done ad-hoc testing.