Bugzilla – Bug 623
GenerateNamedCharactersCpp.java should generate static member declarations for VALUES and WINDOWS_1252 as well as NAMES
Last modified: 2009-08-07 17:09:50 CEST
The currently-committed version of nsHtml5NamedCharacters.cpp intializes all three static data members of the nsHtml5NamedCharacters class:
But the current version of GenerateNamedCharactersCpp.java only generates code to initialize NAMES:
out.write("" + cppTypes.arrayTemplate() + "<"
+ cppTypes.arrayTemplate() + "<" + cppTypes.charType() + ","
+ cppTypes.intType() + ">," + cppTypes.intType() + "> "
+ cppTypes.classPrefix() + "NamedCharacters::NAMES;\n");
This results in "undefined symbols" link errors on all tryserver platforms.
Created attachment 111 [details]
Patch to add the other two declarations
This patch needs to be applied in translator-src with patch level -p1.
Checked in. Thanks!