Bug 623 – GenerateNamedCharactersCpp.java should generate static member declarations for VALUES and WINDOWS_1252 as well as NAMES

NOTE: The current preferred location for bug reports is the GitHub issue tracker.

Bug 623 - GenerateNamedCharactersCpp.java should generate static member declarations for VALUES and WINDOWS_1252 as well as NAMES


Summary:	GenerateNamedCharactersCpp.java should generate static member declarations fo...

Status:	RESOLVED FIXED

Product:	Validator.nu
Classification:	Unclassified
Component:	HTML parser
Version:	HEAD
Hardware:	All All

Importance:	P2 normal
Assigned To:	Ben Newman

URL:

Depends on:
Blocks:	622
	Show dependency tree / graph

Reported:	2009-07-22 01:58 CEST by Ben Newman
Modified:	2009-08-07 17:09 CEST (History)
CC List:	1 user (show)

See Also:

Attachments
Patch to add the other two declarations (2.63 KB, patch) 2009-07-22 02:02 CEST, Ben Newman	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Newman 2009-07-22 01:58:49 CEST

The currently-committed version of nsHtml5NamedCharacters.cpp intializes all three static data members of the nsHtml5NamedCharacters class:

  http://hg.mozilla.org/mozilla-central/file/d3e0648a5d54/parser/html/nsHtml5NamedCharacters.cpp#l8

But the current version of GenerateNamedCharactersCpp.java only generates code to initialize NAMES:

  out.write("" + cppTypes.arrayTemplate() + "<"
          + cppTypes.arrayTemplate() + "<" + cppTypes.charType() + ","
          + cppTypes.intType() + ">," + cppTypes.intType() + "> "
          + cppTypes.classPrefix() + "NamedCharacters::NAMES;\n");

This results in "undefined symbols" link errors on all tryserver platforms.

Comment 1 Ben Newman 2009-07-22 02:02:35 CEST

Created attachment 111 [details]
Patch to add the other two declarations

This patch needs to be applied in translator-src with patch level -p1.

Comment 2 Henri Sivonen 2009-08-07 17:09:50 CEST

Checked in. Thanks!