NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 623 - should generate static member declarations for VALUES and WINDOWS_1252 as well as NAMES should generate static member declarations fo...
Classification: Unclassified
Component: HTML parser
All All
: P2 normal
Assigned To: Ben Newman
Depends on:
Blocks: 622
  Show dependency treegraph
Reported: 2009-07-22 01:58 CEST by Ben Newman
Modified: 2009-08-07 17:09 CEST (History)
1 user (show)

See Also:

Patch to add the other two declarations (2.63 KB, patch)
2009-07-22 02:02 CEST, Ben Newman

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Newman 2009-07-22 01:58:49 CEST
The currently-committed version of nsHtml5NamedCharacters.cpp intializes all three static data members of the nsHtml5NamedCharacters class:

But the current version of only generates code to initialize NAMES:

  out.write("" + cppTypes.arrayTemplate() + "<"
          + cppTypes.arrayTemplate() + "<" + cppTypes.charType() + ","
          + cppTypes.intType() + ">," + cppTypes.intType() + "> "
          + cppTypes.classPrefix() + "NamedCharacters::NAMES;\n");

This results in "undefined symbols" link errors on all tryserver platforms.
Comment 1 Ben Newman 2009-07-22 02:02:35 CEST
Created attachment 111 [details]
Patch to add the other two declarations

This patch needs to be applied in translator-src with patch level -p1.
Comment 2 Henri Sivonen 2009-08-07 17:09:50 CEST
Checked in. Thanks!