NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 366 - RFE: rename hyperlink attributes with "shared-hyperlink.attrs." pattern prefix
RFE: rename hyperlink attributes with "shared-hyperlink.attrs." pattern prefix
Status: RESOLVED FIXED
Product: Validator.nu
Classification: Unclassified
Component: HTML5 schema
HEAD
All All
: P2 enhancement
Assigned To: Henri Sivonen
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-22 07:34 CET by Michael[tm] Smith
Modified: 2009-01-04 17:18 CET (History)
0 users

See Also:


Attachments
patch with proposed change (7.10 KB, patch)
2008-12-22 07:42 CET, Michael[tm] Smith
Details
updated patch (6.78 KB, patch)
2008-12-22 12:13 CET, Michael[tm] Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2008-12-22 07:34:08 CET
The spec essentially defines the values of the hyperlink attributes -- href, target, ping, rel, media, hreflang, and type -- in a common section[1] independent from the particular elements they can be used on. And though the schema currently has separate per-element pattern definitions for all the hyperlink attributes, the separate definitions for a particular attribute all define it with the same datatype.

[1] http://www.whatwg.org/specs/web-apps/current-work/#hyperlink-elements

Anyway, that's all just a roundabout way of saying that it would seem to make some sense to instead define the attribute using a "shared-hyperlink.attrs." pattern prefix (instead of a per-element prefix) -- similar to the "shared-form.attrs." case.
Comment 1 Michael[tm] Smith 2008-12-22 07:42:19 CET
Created attachment 29 [details]
patch with proposed change

Note that the part of this patch that changes the embed.rnc file duplicates part of the patch 28 for bug 365:

http://bugzilla.validator.nu/attachment.cgi?id=28

I couldn't figure out how to generate a diff minus the patch 28 changes. So because of that, the embed.rnc part of this patch will currently fail to get applied under any circumstances; it will fail both if patch 28 has not been applied and if it has been applied.

If/when patch 28 is applied, I can (if you want) generate an updated patch with just the changes for this particular bug.
Comment 2 Michael[tm] Smith 2008-12-22 12:13:09 CET
Comment on attachment 29 [details]
patch with proposed change

flubbed part of this; fixed patch to follow
Comment 3 Michael[tm] Smith 2008-12-22 12:13:51 CET
Created attachment 33 [details]
updated patch

I had deleted area.attrs.alt by accident; this restores it
Comment 4 Henri Sivonen 2009-01-04 17:18:24 CET
Checked in. Not deployed yet. Thanks.