NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 356 - add bb element
add bb element
Status: RESOLVED FIXED
Product: Validator.nu
Classification: Unclassified
Component: HTML5 schema
HEAD
All All
: P2 normal
Assigned To: Henri Sivonen
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-15 06:59 CET by Michael[tm] Smith
Modified: 2009-01-04 16:44 CET (History)
0 users

See Also:


Attachments
patch with suggested change (1.65 KB, patch)
2008-12-15 07:00 CET, Michael[tm] Smith
Details
another attempt; revised for case of no type attribute specified (1.93 KB, patch)
2008-12-15 08:44 CET, Michael[tm] Smith
Details
hopefully final version (1.05 KB, patch)
2008-12-15 09:39 CET, Michael[tm] Smith
Details
updated patch the dispenses with the split/notype stuff (679 bytes, patch)
2008-12-27 20:25 CET, Michael[tm] Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2008-12-15 06:59:45 CET
see attached patch, which adds the <bb> element using a schema structure similar to that for existing elements in the schema that have an enumerated type attributed (button, input, and command)
Comment 1 Michael[tm] Smith 2008-12-15 07:00:55 CET
Created attachment 15 [details]
patch with suggested change
Comment 2 Michael[tm] Smith 2008-12-15 08:29:36 CET
Comment on attachment 15 [details]
patch with suggested change

flubbed this; will submit correct patch later
Comment 3 Michael[tm] Smith 2008-12-15 08:44:31 CET
Created attachment 16 [details]
another attempt; revised for case of no type attribute specified

So I realize the spec says the case of a bb element with no type attribute specified is quite different from the when type=makeapp; seems that the schema also needs to reflect that difference clearly, and this patch tries to do that.
Comment 4 Michael[tm] Smith 2008-12-15 09:37:49 CET
Comment on attachment 16 [details]
another attempt; revised for case of no type attribute specified

flubbed; hadn't realized you already got contex=h:bb in assertions; will post revised patch after
Comment 5 Michael[tm] Smith 2008-12-15 09:39:47 CET
Created attachment 17 [details]
hopefully final version

see previous comments; this removes the redundant/unnecessary h:bb addition to assertions.sch
Comment 6 Michael[tm] Smith 2008-12-27 20:25:26 CET
Created attachment 50 [details]
updated patch the dispenses with the split/notype stuff

In retrospect, splitting bb just for the miissing type case seems like overkill. Although I think it might make sense if/when any additional enumerated type values for bb are added, for now it sees simpler and better to leave it unsplit. So that's what this updated patch does.
Comment 7 Henri Sivonen 2009-01-04 16:44:25 CET
Checked in. Thanks. (Not deployed at validator.nu yet.)