Bug 319 – Make probable cause with unquoted attribute values more probable

NOTE: The current preferred location for bug reports is the GitHub issue tracker.

Bug 319 - Make probable cause with unquoted attribute values more probable


Summary:	Make probable cause with unquoted attribute values more probable

Status:	NEW

Product:	Validator.nu
Classification:	Unclassified
Component:	HTML parser
Version:	HEAD
Hardware:	All All

Importance:	P2 normal
Assigned To:	Nobody

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-10-30 16:39 CET by Henri Sivonen
Modified:	2009-11-23 17:17 CET (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Henri Sivonen 2008-10-30 16:39:35 CET

16:02 < zcorpan> hsivonen: Error: " in an unquoted attribute value. Probable 
                 causes: Attributes running together or a URL query string in 
                 an unquoted attribute value.
16:03 < zcorpan> hsivonen: is the latter really a probable cause?
16:03 < zcorpan> hsivonen: (it is for = but i don't think it is for " or ')
16:05 < zcorpan> hsivonen: probably cause is forgetting the starting " or ' (at 
                 least if the next character is > or whitespace)
16:05 < zcorpan> s/y/e/
16:05 < zcorpan> (or maybe regardless of the next character)

Comment 1 Simon Pieters 2008-10-30 17:10:32 CET

Compare

<p title=Hello">
<p title=Hello World">

The latter says "Probable cause: Matching quote missing somewhere earlier."

Although that's not true in these cases:

<p title=O'Reilly>
<p onclick=alert("Hello")>

They might not be common enough to differentiate, but if you will then a more appropriate message for those would probably be something like "You can't use " or ' in unquoted attributes".