Bug 1016 – picture-source checks are applied on video-source also

NOTE: The current preferred location for bug reports is the GitHub issue tracker.

Bug 1016 - picture-source checks are applied on video-source also


Summary:	picture-source checks are applied on video-source also

Status:	RESOLVED FIXED

Product:	Validator.nu
Classification:	Unclassified
Component:	General
Version:	HEAD
Hardware:	All All

Importance:	P2 normal
Assigned To:	Nobody

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-01-15 13:06 CET by Simon Pieters
Modified:	2015-02-15 17:54 CET (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Pieters 2015-01-15 13:06:59 CET

<video>
 <source src="foo">
 <img src="bar" srcset="baz 2x" alt="">
</video>

Error: A source element that has a following sibling source element or img element with a srcset attribute must have a media attribute and/or type attribute.

Should only run picture-source checks if the parent is a picture.

Comment 1 Michael[tm] Smith 2015-01-17 19:43:26 CET

Thanks for catching this. Have added it to the TODO list

Comment 2 Michael[tm] Smith 2015-02-15 17:54:42 CET

https://github.com/validator/validator/commit/cd9f14ebc9d10ad41f3a008e022bfbbeccdd5074