NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 354 - split command into separate patterns, similar to button and input
split command into separate patterns, similar to button and input
Classification: Unclassified
Component: HTML5 schema
All All
: P2 normal
Assigned To: Henri Sivonen
Depends on:
  Show dependency treegraph
Reported: 2008-12-12 20:40 CET by Michael[tm] Smith
Modified: 2009-01-04 16:44 CET (History)
0 users

See Also:

patch with proposed changes (2.95 KB, patch)
2008-12-12 20:41 CET, Michael[tm] Smith
change command.attrs.radiogroup to (482 bytes, patch)
2009-01-02 07:51 CET, Michael[tm] Smith

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2008-12-12 20:40:35 CET
it seems like command is a sub-typed/multi-typed element similar to button and input, so splitting it into multiple patterns would seem to make sense (see attached patch)
Comment 1 Michael[tm] Smith 2008-12-12 20:41:00 CET
Created attachment 13 [details]
patch with proposed changes
Comment 2 Henri Sivonen 2008-12-20 19:06:33 CET
Checked in as r366 with wrong commit message. Thanks.
Comment 3 Michael[tm] Smith 2009-01-02 07:49:40 CET
Reopening this because I found a minor problem in the patch that needs fixing.
Comment 4 Michael[tm] Smith 2009-01-02 07:51:23 CET
Created attachment 51 [details]
change command.attrs.radiogroup to
Comment 5 Henri Sivonen 2009-01-04 16:30:21 CET
(In reply to comment #4)
> Created an attachment (id=51) [details]
> change command.attrs.radiogroup to

Reference to undefined pattern “â€.
Line: 124 Col: 41

Is the pattern defined by a patch on another bug?
Comment 6 Henri Sivonen 2009-01-04 16:34:16 CET
Nevermind. I see what happened.
Comment 7 Henri Sivonen 2009-01-04 16:44:42 CET
Checked in. Thanks. (Not deployed at yet.)