Bug 935 – Nullreference bug in nu.validator.htmlparser.xom.HtmlBuilder ctor

NOTE: The current preferred location for bug reports is the GitHub issue tracker.

Bug 935 - Nullreference bug in nu.validator.htmlparser.xom.HtmlBuilder ctor


Summary:	Nullreference bug in nu.validator.htmlparser.xom.HtmlBuilder ctor

Status:	RESOLVED FIXED

Product:	Validator.nu
Classification:	Unclassified
Component:	HTML parser
Version:	HEAD
Hardware:	All All

Importance:	P2 major
Assigned To:	Nobody

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-23 23:02 CEST by iliev17
Modified:	2012-09-21 15:21 CEST (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description iliev17 2012-07-23 23:02:34 CEST

public HtmlBuilder(SimpleNodeFactory nodeFactory, XmlViolationPolicy xmlPolicy) {
        super();
        this.simpleNodeFactory = nodeFactory;
        this.treeBuilder = new XOMTreeBuilder(nodeFactory);
        this.driver = null;
//Nullreference
        this.driver.setXmlnsPolicy(XmlViolationPolicy.ALTER_INFOSET); 
        setXmlPolicy(xmlPolicy);
    }

Comment 1 Jonathan Hess 2012-08-01 21:49:39 CEST

Here's my workaround until this gets fixed. I use the nu.validator SAX parser to feed XOM's Builder.


	public static Document parseHtmlFile(File file) {
		nu.validator.htmlparser.sax.HtmlParser parser = new nu.validator.htmlparser.sax.HtmlParser(){
			@Override
			public void setFeature(String name, boolean value)
					throws SAXNotRecognizedException, SAXNotSupportedException {
				try {
					super.setFeature(name, value);
				} catch(Exception e) {
					System.out.println("Could not set "+name);
				}
			}
		};

		Builder builder = new Builder(parser, false);
		try {
			Document doc = builder.build(new InputStreamReader(new FileInputStream(file), "UTF-8"));
			return doc;
		} catch(Exception e) {
			throw new RuntimeException(e);
		}
	}

Comment 2 Henri Sivonen 2012-09-21 15:21:39 CEST

Whoa. How did *that* happen?

Fixed: https://hg.mozilla.org/projects/htmlparser/rev/1d03b97674c8

I’ll make a new release after some more fixes. Hopefully next week.