NOTE: The current preferred location for bug reports is the GitHub issue tracker.
Bug 377 - RFE: rename/refactor pattern definitions for enctype, method, and action attributes on form elements
RFE: rename/refactor pattern definitions for enctype, method, and action attr...
Status: RESOLVED FIXED
Product: Validator.nu
Classification: Unclassified
Component: HTML5 schema
HEAD
All All
: P2 enhancement
Assigned To: Henri Sivonen
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-24 10:39 CET by Michael[tm] Smith
Modified: 2009-01-09 16:50 CET (History)
0 users

See Also:


Attachments
patch with proposed changes (4.54 KB, patch)
2008-12-24 10:46 CET, Michael[tm] Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael[tm] Smith 2008-12-24 10:39:08 CET
The HTML5 draft has shared/common definitions for the enctype, method, and action (instead of per-element definitions for them). It seems like it might be worthwhile to have the schema also use share definitions for the corresponding patterns (for consistency, and to reduce redundancy and ease maintenance of the schema).
Comment 1 Michael[tm] Smith 2008-12-24 10:46:58 CET
Created attachment 40 [details]
patch with proposed changes

In webforms.rnc, this patch renames the patterns for the action, method, and enctype attributes on the <form> element to shared-form.attrs.action, shared-form.attrs.method, shared-form.attrs.enctype -- even though in the case of webforms.rnc they are only allowed/referenced by the <form> element. The rationale for that it simply to provide the hooks to make it easier to add those as shared definitions in the webforms2.rnc file, and to easily extend them as needed for the case of the <form> element (while allowing them to be referenced as shared patterns instead of just specific patterns for only the <form> element).

As with some other recent patches, this one also includes some overlap with previous patches.
Comment 2 Henri Sivonen 2009-01-09 16:50:13 CET
Check-in coming up. Thanks.